London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 4 | Implement cowsay in Python#275
London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 4 | Implement cowsay in Python#275aydaeslami wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
aydaeslami
added
📅 Sprint 4
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
bot
removed
the
Needs Review
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
aydaeslami
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
I have a few comments about some issues here. You may want to take another attempt at this task
| prog="cowsay", | ||
| description="Simple cowsay clone", | ||
| ) | ||
| parser.add_argument("--animal",choices=cowsay.list_cows(), help="The animal to be saying things.") |
There was a problem hiding this comment.
Try running this script without any arguments - what do you expect to happen? does the actual output match this?
LonMcGregor
added
Reviewed
aydaeslami
added
the
Needs Review
|
Good work cleaning up the extra line. What about my other comment - are you able to run this code without any errors? When I run it, it tells me there is an issue with the module missing an attribute. |
LonMcGregor
removed
the
Needs Review
|
Thank you @LonMcGregor for checking. The only time I received an error was when I ran the code without parameters, which I believe is expected based on the requirement in the README file. Otherwise, I don’t receive any other errors. It might be helpful if you could let me know how you are running it. |
aydaeslami
added
the
Needs Review
|
If I compare how you are using the animal list It seems to be different. Does cowsay.list_cows() give correct output for you? |
LonMcGregor
removed
the
Needs Review
2 participants
This PR includes implementing cowsay in Python and using a virtual environment.